Allow : in build docker image name

[sxa]

Also escapes the - character and adjusts the formatting of the error message. This was causing a problem for the riscv64 which use a slightly different format for these values and is causing a build job failure after the merging of #873

[github-actions]

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

[smlambert]

In the long-run, is there a way to establish an actual naming convention and have riscv follow it, rather than having to make concessions for every case that doesn't follow a convention?

[sxa]

In the long-run, is there a way to establish an actual naming convention and have riscv follow it, rather than having to make concessions for every case that doesn't follow a convention?

We've never established an explicit convention but what RISC-V is as close as it reasonably be to everything else so is absolutely fine with a tag with the platform name in it and a parameter to tell docker that it's using a non-native container (for performance reasons) which is why it's different. It's a case of trailblazing and needing to have special parameters to do that. The parameters are broadly consistent with what Alibaba did for test.

Yeah we could make the convention more fixed, but it would have to include what we've done in this situation.