-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jenkins machine configuration on Windows test machines need to update #23
Comments
I've updated the git tool location in Jenkins for node Please check to see if this is sufficient. |
Problem stays. See comment in adoptium/aqa-tests#37 Could someone with "root/Admin" permission log in and wipe out the workspace C:\Users\jenkins\workspace\openjdk_test_x86-64_windows? ( I only have jenkins permission) In this way with a clean workspace we can try if problem stays. As I mentioned initially it happened when test machine is offline( either by regular jenkins restart or unknown reason), which means probably some configuration changes. Thanks. |
@tellison Maybe you and I can figure this out today? |
Suppose someone has responded my former comment. No this issue anymore in recent build. |
@sophia-guo what is the current status of this? |
Last build I ran https://ci.adoptopenjdk.net/view/work%20in%20progress/job/openjdk_test_x86-64_windows/252/console, same issue. |
right okay, we need to get this fixed |
We have disabled the Windows test builds until we can get a clean Windows machine: @gdams - perhaps you can give myself and @sophia-guo a quick tutorial on how to reconfigure the machines at adopt / run ansible playbooks, we can help bring up new test machines, or refresh ones that are in a bad state. |
@gdams will be reprovisioning this machine over the next day or two. |
system has been reprovisioned, playbook ran needs to be added to Jenkins @gdams can you do that? |
okay added to jenkins. @smlambert can you let us know if this new machine fixes the issues? |
seems a different issue: |
Based on investigation from @pnstanton The full cygwin install wasn't in the system |
@sxa555 sorry for confusion. For the second issue if you run get1.sh the job will run in a new cmd window, which is similar to jenkins job. If jenkins job use bat to run a script the job will be in a new cmd window. The original window(jenkins job console) will not get any output. If you see this job https://ci.adoptopenjdk.net/view/work%20in%20progress/job/TestBuild_Sandbox/259/console you will see: |
To be clear I remote as a jenkins user and jenkins jobs is also working as a jenkins user. |
If you run the script with When I run |
(For the record, rebooting didn't make any difference to this) |
Yes, in jenkins pipeline if using shell step invoke shell script on windowns we do get the issue about the Windows UNIX ending issue:
Similar as running
It may not be guaranteed there is dos2unix on window machines. So in jenkins job on Windows I'm trying the bat step to invoke the shell script, which don't have that windows ending issue. However hit this cygwin issue. In jenkins file this step is:
|
Did you mean using wget in command line? Yes, if using wget in cmd directly it's ok as I mentioned in above comment. |
But is there a reason not to do that in your cmd script instead of calling a UNIX shell script? |
I tried reinstalling cygwin. It made no difference. Eventually discovered that Although I now have two versions of cygwin on the machine. The new current one has been set up using exactly what's in the Windows playbook (plus wget which wasn't there). Let me know if it's working. |
I just tried and still got: |
Try now - I think the change I made yesterday may only have affected the Administrator account - the jenkins account still seemed to have the previous association (Either that or something changed it back :-) ) |
Now if I run script directly in cmd, cygwin64 I will hit that windows ending format issue. If I run script directly in gitbash I will get: which is the same behavior as I run script in jenkins job. |
So what is the current problem you are facing that's holding you up? Do you need the bash supplied with git? |
Can you give me recreate instructions because as far as I can see it's working correctly in this situation |
I saw that you have a openjdk-tests directory, so try following in cmd and you should be able to reproduce: |
In gitbash: jenkins@test-packet-x64-windows-2012r2-1 MINGW64 ~/sxa |
My last comment appears to have got lost so repeating it: Why are you choosing to run from the git bash shell instead of cygwin's shell when running the script from there? I've been able to reproduce the issue you had running from Have these scripts been run in another environment on Windows before? |
From discussion in slack - let's try using the existing Windows version of |
I will try that. If I recall correctly even using get.bat jenkins job is using cygwin instead of gitbash. Though I'm not sure. Will update . |
I have updated story for windows only to test if the issue is fixed. Using get.bat I haven't hit the issue of wget cygwin issue. But realized that we need the perl JSON and Text::CSV module installed on test machine. And now seemed it's not there. |
@sophia-guo Can you give me recreate instructions please? As far as I can see Can you check what your |
@sxa555 perl JSON and Text::CSV module are needed by our test framework TestKitGen, which is in Eclipse openj9 repo. |
@sophia-guo I understand that - but do you get the problem when running with the Strawberry perl implementation which has had additional modules installed. EDIT: The strawberry perl installation on that machine should be the default perl for the jenkins user and does already have |
@sxa555 I'm not sure which perl is picked up in jenkins job. I have printout the PATH right before I call perl: Remote to the machine and running the perl in cmd and got same issue. And checked that Strawberry actually is under c:\Strawberry\perl\bin and using c:\Strawberry\perl\bin\perl I didn't get that issue. Maybe this wrong path is the issue? |
Hmmm yep - I had to restart the machine to get the jenkins agent to update the path properly to be |
Using our former test build story on Windows (using batch script instead of shell script) two successful test builds have finished without this configure issue. openjdk_test_x86-64_windows . Next step would be updates windows test jobs. Close this issue. |
Openjdk tests build on windows got failures for permission issue:
java.nio.file.AccessDeniedException: C:\Users\jenkins\workspace\openjdk_test_x86-64_windows\openjdk-test\OpenJDK_Playlist\openjdk-jdk8u\jdk\test\sun\management\windows\revokeall.exe
According to last two comments in adoptium/aqa-tests#37 (comment) Jenkins machine configuration need to update to specify the tools location for git.
The issue are still there suppose the configuration isn't be updated.
The text was updated successfully, but these errors were encountered: