Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jdk12 to build pipelines #916

Closed
lumpfish opened this issue Feb 26, 2019 · 7 comments
Closed

Add jdk12 to build pipelines #916

lumpfish opened this issue Feb 26, 2019 · 7 comments
Assignees
Labels
enhancement Issues that enhance the code or documentation of the repo in any way
Milestone

Comments

@lumpfish
Copy link
Contributor

Amend scripts as required to build openjdk12-hotspot and openjdk12-openj9.

@lumpfish
Copy link
Contributor Author

lumpfish commented Feb 26, 2019

  1. Changed https://ci.adoptopenjdk.net/job/build-scripts/job/utils/job/build-pipeline-generator/ to generate a pipeline for jdk12
  2. Changed the generated https://ci.adoptopenjdk.net/job/build-scripts/job/openjdk12-pipeline/ to point at a fork of openjdk-build (this will be overwritten overnight when the generate pipeline job runs again).
  3. Added a JDK12_CORE_VERSION definition and included it in various if statements, similar to jdk11
  4. Added stanzas to change the JDK_BOOT_DIR to jdk11 for jdk12 and HEAD
  5. Fixed the wgets for jdk11 for JDK_BOOT_DIR to identify a single AdoptOpenJDK build
  6. Removed the openssl build options for openjdk12-openj9 (the openssl support has not yet been committed to openjdk12-openj9, the options will need reinstating when it is (hopefully in the next few days)).

With these changes linux_x86-64 for openjdk12-openj9 now builds. Other platforms fail:

  1. For Windows, setting the JDK_BOOT_DIR is not done (can't see where it's done)
  2. For Mac the downloaded boot jdk does not have the directory structure the build scripts assume
  3. AIX build machine has an issue with ramdisk0 which I assume is unrelated to the build
  4. Linux S390x and linux ppcle: the build fails complaining about some X11 prereqs

Builds https://ci.adoptopenjdk.net/job/build-scripts/job/openjdk12-pipeline/14/ and https://ci.adoptopenjdk.net/job/build-scripts/job/openjdk12-pipeline/15 (rerun with Mac only) contain the current errors.

@lumpfish lumpfish mentioned this issue Feb 26, 2019
@lumpfish
Copy link
Contributor Author

Created #917 with the work achieved so far.

@karianna karianna added the enhancement Issues that enhance the code or documentation of the repo in any way label Feb 26, 2019
@karianna karianna added this to the February 2019 milestone Feb 26, 2019
@lumpfish
Copy link
Contributor Author

Support for openssl has now been added for openjdk12-openj9. I've updated the relevant builds args in the jdk12_support branch in #917.

@lumpfish
Copy link
Contributor Author

Raised #924 for the macos jdk boot dir issue.

@lumpfish
Copy link
Contributor Author

Issue with X11 prereqs on Linux should be fixed by adoptium/infrastructure#640.

@karianna karianna modified the milestones: February 2019, March 2019 Mar 2, 2019
@lumpfish
Copy link
Contributor Author

lumpfish commented Mar 4, 2019

Raised #938 for the missing X11 prereqs. Change to ansible scripts in adoptium/infrastructure#640 did not fix the issue because those scripts are not running successfully on s390x and ppcle Linux.

@sxa
Copy link
Member

sxa commented Mar 11, 2019

Adding some PR references for historic completeness: #917 #923 #943

There have been some subsequent queries over version strings: #935 #935 but these are unlikely to be directly related to the changes to enable JDK12.

On that basis I am closing this issue.

@sxa sxa closed this as completed Mar 11, 2019
@sxa sxa self-assigned this Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues that enhance the code or documentation of the repo in any way
Projects
None yet
Development

No branches or pull requests

3 participants