Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java 8u212 will be able to use vendor name flag #984

Open
karianna opened this issue Mar 21, 2019 · 4 comments
Open

Java 8u212 will be able to use vendor name flag #984

karianna opened this issue Mar 21, 2019 · 4 comments
Assignees
@johnoliver
Labels
enhancement Issues that enhance the code or documentation of the repo in any way
Milestone
March 2021

Comments

@karianna
Copy link
Contributor

just a heads-up: --with-vendor-name coming with next CPU update for 8u. https://bugs.openjdk.java.net/browse/JDK-8221171
@karianna karianna added the enhancement Issues that enhance the code or documentation of the repo in any way label Mar 21, 2019
@karianna karianna added this to the Backlog milestone Mar 21, 2019
@jerboaa
Copy link
Contributor

jerboaa commented Apr 11, 2019

@karianna That would be 8u212 (April CPU), not 8u222. I cannot fix the name myself.

@karianna karianna changed the title Java 8u 222 will be able to use vendor name flag Java 8u212 will be able to use vendor name flag Apr 11, 2019
@M-Davies
Copy link

Looking at the build scripts, we are using --with-vendor-name for JDK8/HS whenever we have ADOPT_PATCHES set to True. Seeing as this remains at True for 99% of the time, can this be closed @karianna ?

@karianna karianna modified the milestones: Backlog, May 2020 May 23, 2020
@karianna
Copy link
Contributor Author

Looking at the build scripts, we are using --with-vendor-name for JDK8/HS whenever we have ADOPT_PATCHES set to True. Seeing as this remains at True for 99% of the time, can this be closed @karianna ?

Pulling in @johnoliver for a final check, but I think we can close this yes.

@karianna karianna modified the milestones: May 2020, June 2020 Jun 1, 2020
@karianna karianna modified the milestones: June 2020, July 2020 Jul 1, 2020
@karianna karianna modified the milestones: July 2020, August 2020 Aug 3, 2020
@karianna karianna modified the milestones: August 2020, September 2020 Sep 1, 2020
@austin0
Copy link
Contributor

austin0 commented Sep 24, 2020

@johnoliver can this be closed now that #2073 has one in, jdk8u now always has a vendor name (Default "AdoptOpenJDK").

@karianna karianna modified the milestones: September 2020, November 2020 Nov 3, 2020
@karianna karianna modified the milestones: November 2020, December 2020 Jan 3, 2021
@karianna karianna modified the milestones: December 2020, March 2021 Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnoliver johnoliver

Labels
enhancement Issues that enhance the code or documentation of the repo in any way
Projects
None yet
Milestone
March 2021
Development

No branches or pull requests
5 participants
@karianna @jerboaa @johnoliver @austin0 @M-Davies