Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/emit eventstore events #149

Merged
merged 12 commits into from
Aug 29, 2019
Merged

Feature/emit eventstore events #149

merged 12 commits into from
Aug 29, 2019

Conversation

bobbytes
Copy link
Contributor

Emit nodejs events before and after an eventstore event including timestamp.

@nanov
Copy link
Contributor

nanov commented Aug 26, 2019

Hi @DaNautilus it seems you have done a pretty good job encapsulating this functionally into a separated module that wraps each the original store implementation.

Is there a real need for that to be enabled by default ( ie lines 75,76 in index.js ), and for it to be a part from this library? What is the exact use case of this?

@nanov
Copy link
Contributor

nanov commented Aug 27, 2019

I am waiting for the comments of @DaNautilus before taking further actions.
Without going into implementation details, i would leave this as optional add-on ( still can be a part of the library ) instead of enabling it by default.

@bobbytes
Copy link
Contributor Author

bobbytes commented Aug 28, 2019

@nanov To support out maintenance we'd like to measure database events. Our cloud provider does not provide any database metrics and that's why we have to do it manually.

@adrai did it already for our denormalizers in node-viewmodel. But unfortunately we miss this feature for our eventstore.

And yes, you're right, there's no need to enable it by default. I'm going to implement a solution for that.

@nanov
Copy link
Contributor

nanov commented Aug 28, 2019

Great!

I am going to review, merge and release this later on today!

@nanov nanov merged commit f5ce3f0 into thenativeweb:master Aug 29, 2019
@nanov
Copy link
Contributor

nanov commented Aug 29, 2019

Landed in v1.15.0.

@bobbytes
Copy link
Contributor Author

Great, thanks a lot 👍🏻 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants