-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/emit eventstore events #149
Feature/emit eventstore events #149
Conversation
Hi @DaNautilus it seems you have done a pretty good job encapsulating this functionally into a separated module that wraps each the original store implementation. Is there a real need for that to be enabled by default ( ie lines 75,76 in index.js ), and for it to be a part from this library? What is the exact use case of this? |
I am waiting for the comments of @DaNautilus before taking further actions. |
@nanov To support out maintenance we'd like to measure database events. Our cloud provider does not provide any database metrics and that's why we have to do it manually. @adrai did it already for our denormalizers in node-viewmodel. But unfortunately we miss this feature for our eventstore. And yes, you're right, there's no need to enable it by default. I'm going to implement a solution for that. |
Great! I am going to review, merge and release this later on today! |
Landed in v1.15.0. |
Great, thanks a lot 👍🏻 🎉 |
Emit nodejs events before and after an eventstore event including timestamp.