Fix stream revision # after snapshot #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In getFromSnapshot if there are no events in the stream after the snapshot, the returned stream object had a lastRevision of -1 which causes the next event to be created with a revision number of 0, breaking the event stream. This fix set's the last revision equal to the snapshot's revision number.
|
Updated the pull request with the new test. |
|
thanks |
adrai
added a commit
that referenced
this pull request
Jan 30, 2015
Fix stream revision # after snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In getFromSnapshot if there are no events in the stream after the snapshot, the
returned stream object had a lastRevision of -1 which causes the next event to
be created with a revision number of 0, breaking the event stream. This fix
set's the last revision equal to the snapshot's revision number.