Support mongo connection string #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll try to look at it tomorrow... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick PR for #68.
Use can now pass in a mongo connection string which is a lot more powerful than passing in individual host/port or servers.
As discussed in the issue, this is especially useful for supporting different environments (dev/prod etc).
Implemented by converting host/port/db/auth/servers etc to a connection string and using MongoClient.connect, which is more simple than the deprecated way of creating ReplSet/Servet etc depending on the parameters.
All tests pass except some unrelated elasticsearch/redis tests which I do not have installed.