Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis snapshots are retrieved recursively to match 'max revision' option #89

Merged
merged 1 commit into from
Nov 2, 2016

Conversation

rehia
Copy link
Contributor

@rehia rehia commented Nov 2, 2016

snapshots where loaded all together to only use the latest with revMax === -1, causing performance issues
now snapshots are loaded from redis recursively to find the one that match revMax option.
see
See #24

snapshots where loaded all together to only use the latest with revMax === -1, causing performance issues
now snapshots are loaded from redis recusively to find the one that match revMax option
@adrai
Copy link
Contributor

adrai commented Nov 2, 2016

looks nice

@adrai adrai merged commit c0befc9 into thenativeweb:master Nov 2, 2016
@rehia
Copy link
Contributor Author

rehia commented Nov 3, 2016

Thanks for your quick merge and publish !
Already in production !

@adrai
Copy link
Contributor

adrai commented Nov 3, 2016

cool!
may I ask for which product/service/software?

@rehia
Copy link
Contributor Author

rehia commented Nov 3, 2016

https://www.tweetping.net

On Thu, Nov 3, 2016 at 2:01 PM, Adriano Raiano notifications@github.com
wrote:

cool!
may I ask for which product/service/software?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#89 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACIw4mbflCIKT5aisVoLIrD5laE7Yvhyks5q6dsSgaJpZM4KnjLv
.

rehia added a commit to rehia/node-eventstore that referenced this pull request Jan 4, 2017
…ion (thenativeweb#89)

snapshots where loaded all together to only use the latest with revMax === -1, causing performance issues
now snapshots are loaded from redis recusively to find the one that match revMax option
rehia added a commit to rehia/node-eventstore that referenced this pull request Jan 4, 2017
…ion (thenativeweb#89)

snapshots where loaded all together to only use the latest with revMax === -1, causing performance issues
now snapshots are loaded from redis recusively to find the one that match revMax option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants