Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add event, speaker, kind, topics talks filter and asc/desc order_by #433

Merged
merged 3 commits into from
Nov 23, 2024

Conversation

adrienpoly
Copy link
Owner

It doesn't do much at this point but it give the possibility to manually filter the talks results from the url

Examples:

  • /talks?kind=keynote&order_by=date_asc
  • /talks?speaker=marco-roth&order_by=date_desc&topic=hotwire

This is the foundation to build filters in addition to the search

Copy link
Collaborator

@marcoroth marcoroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

app/controllers/talks_controller.rb Outdated Show resolved Hide resolved
adrienpoly and others added 2 commits November 23, 2024 09:20
Co-authored-by: Marco Roth <marco.roth@intergga.ch>
@adrienpoly adrienpoly merged commit 4afe5bc into main Nov 23, 2024
4 checks passed
@adrienpoly adrienpoly deleted the talks-filters branch November 23, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants