Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Volume or page given as a roman numeral will cause bibcode generator to fail #37

Open
seasidesparrow opened this issue Nov 5, 2024 · 0 comments
Open

Volume or page given as a roman numeral will cause bibcode generator to fail #37

seasidesparrow opened this issue Nov 5, 2024 · 0 comments
Assignees
@seasidesparrow

Comments

@seasidesparrow
Copy link
Member

A parsed record included a "volume" of "XLVIII". Bibcode generator used this verbatim, resulting in len(bibcode)>19, which returns None silently.

  • convert roman numerals to integer in _get_volume
  • BibcodeGenerator should raise an exception if len(bibcode) != 19, not return None -- let adsmanparse.translator deal with a missing bibcode
@seasidesparrow seasidesparrow self-assigned this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seasidesparrow seasidesparrow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seasidesparrow