Add SetupSteamApi to Framework #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Haselnussbomber <mail@haselnussbomber.de>
Breaking ChangesType exists in left but not in rightFFXIVClientStructs.FFXIV.Component.GUI: 1AtkEventData: 5
Member exists in left but not in rightFFXIVClientStructs.FFXIV.Component.GUI: 3AtkComponentTextInput: 1
AtkEventType: 2
AtkEventData: 5
|
github-actions
bot
added
the
breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed so that we can manually call
SetupSteamApi()from Dalamud/plugins.The game will automatically tear down the Steam API when shutting itself down, so long as the SteamApi pointer is set (see
Client::System::Framework::Framework_TeardownSteamApi, inlined inFramework#Free.This method must only be called once per session, so callers need to verify first that
IsSteamApiInitializedreturnsfalse, and thatboot/steam_api64.dllis present. If a Steam API is already present, re-calling this method will reinitialize the API, leading to potentially problematic edge cases.Likewise, if this method is called when
boot/steam_api64.dllis not present, it will set the variableFramework#IsSteamGametotrue. However, this does not appear to actually do anything, so perhaps this is safe.