Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove isSet accessors for algebraic structures? #1034

Closed
MatthiasHu opened this issue Aug 25, 2023 · 3 comments · Fixed by #1040
Closed

Remove isSet accessors for algebraic structures? #1034

MatthiasHu opened this issue Aug 25, 2023 · 3 comments · Fixed by #1040
Assignees

Comments

@MatthiasHu
Copy link
Contributor

I propose to delete the following lemmas:

isSetGroup
isSetRing
isSetDistLattice
isSetCommAlgebra
isSetLeftModule
isSetField
isSetAlgebra
isSetLattice
isSetCommRing
isSetAbGroup
isSetOrderedCommMonoid
isSetCommMonoid

They seem unnecessary, since all these algebraic structures expose an is-set field through the inheritance mechanism of the Is<Something> records already (as demonstrated in #1033). Also note that some structures are missing, e.g. Monoid.

I would say it is better to directly use is-set everywhere (and I would be willing to implement that change). Are there other opinions on this?

@felixwellen
Copy link
Collaborator

I agree. One could be unhappy about "public" use of 'is-set' which is not in line with the naming conventions. I am not though. Especially when thinking of using instance resolution to prove h-levels in the future.

@mzeuner
Copy link
Contributor

mzeuner commented Aug 30, 2023

I support that change as well, especially given that only some structures have such a lemma.

@MatthiasHu
Copy link
Contributor Author

Good -- I will do this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants