Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The RingSolver fails to solve some equations #513

Closed
felixwellen opened this issue Feb 20, 2021 · 1 comment
Closed

The RingSolver fails to solve some equations #513

felixwellen opened this issue Feb 20, 2021 · 1 comment

Comments

@felixwellen
Copy link
Collaborator

I found two examples of equations the RingSolver fails to solve:
x · 0r ≡ 0r
and
x · (y - z) ≡ x · y - x · z
Since the examples are small, it should be easy to find the problem and fix it. My guess is, that in the definition of the multiplication of HornerForms, an additional special case has to be considered.

felixwellen added a commit to felixwellen/cubical that referenced this issue Mar 26, 2021
felixwellen added a commit to felixwellen/cubical that referenced this issue Mar 26, 2021
mortberg pushed a commit that referenced this issue Aug 18, 2021
* Issue #513: Write an example that fails

* Issue #513: Add missing simplification, open new goals in the normalization-proof

* Prove that the new zero-detection is compatible with evaluation

* Add computation for evaluation, to abstract over cases

* Refactor

* Refactor

* Prove homomorphism property for +

* Prove homomorphism property for +

* Remove obsolete

* Refactor

* Prove lemmata

* Refactor, new Utility

* Eval is homomorphic for scalar multiplication

* Refactor

* Eval is homomorphic for \cdot

* Fix

* Update comment

* More examples

* Whitespace

* Whitespace

* Remove obsolete options

* Refactor rename
@felixwellen
Copy link
Collaborator Author

Solved by #530.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant