Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hom as instance of AbGroup #635

Merged
merged 3 commits into from
Dec 15, 2021
Merged

Add Hom as instance of AbGroup #635

merged 3 commits into from
Dec 15, 2021

Conversation

barrettj12
Copy link
Contributor

No description provided.

@barrettj12
Copy link
Contributor Author

@mortberg I thought HomAbStr was a better name than HomIsAb, thoughts?

mortberg
mortberg requested changes Dec 15, 2021
View reviewed changes
Copy link
Collaborator

@mortberg mortberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would call it HomAbGroupStr. Apart from this and a comment this looks good to me

Cubical/Algebra/AbGroup/Instances/Hom.agda Outdated Show resolved Hide resolved
@barrettj12 barrettj12 requested a review from mortberg December 15, 2021 14:49
@mortberg mortberg merged commit 024e088 into agda:master Dec 15, 2021
@barrettj12 barrettj12 deleted the hom-is-ab branch December 15, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortberg mortberg mortberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barrettj12 @mortberg