Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for getting make to work on Windows #651

Merged
merged 7 commits into from
Dec 16, 2021

Conversation

barrettj12
Copy link
Contributor

@barrettj12 barrettj12 commented Nov 26, 2021

Fixes #633 (kinda)

Please squash and merge into a single commit.

Copy link
Collaborator

@mortberg mortberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of minor stylistic comments. I don't have windows so cannot test, but I think it's good to have these instructions in case someone else has problems

MAKEWINDOWS.md Outdated Show resolved Hide resolved
INSTALL.md Outdated Show resolved Hide resolved
INSTALL.md Outdated Show resolved Hide resolved
INSTALL.md Outdated Show resolved Hide resolved
INSTALL.md Outdated Show resolved Hide resolved
INSTALL.md Outdated Show resolved Hide resolved
INSTALL.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@Saizan
Copy link
Contributor

Saizan commented Dec 15, 2021

By the way, I don't think INSTALL.md should tell users to use make for agda/cubical, it's not necessary to "install" the library.

In that case if you install Agda through cabal or stack you won't have to run make at all.

@barrettj12
Copy link
Contributor Author

By the way, I don't think INSTALL.md should tell users to use make for agda/cubical, it's not necessary to "install" the library.

In that case if you install Agda through cabal or stack you won't have to run make at all.

True, it's just to test that the installation worked right? I was thinking you could factor this out into a separate section, since this part seems to be repeated verbatim for each installation method.

@Saizan
Copy link
Contributor

Saizan commented Dec 15, 2021

Yeah, make only tests that the installed agda can typecheck all the files of the library.

Btw, I still think it's helpful to know how to get make to work on windows, but probably more for someone contributing so that they can run the tests.

@barrettj12 barrettj12 requested a review from mortberg December 15, 2021 15:29
@barrettj12
Copy link
Contributor Author

@mortberg fixed. @Saizan had a good point that this is not necessary in the INSTALL.md file, so I've reverted this to the current version.

@mortberg
Copy link
Collaborator

Looks good to me!

@mortberg mortberg merged commit cfd3fa6 into agda:master Dec 16, 2021
@barrettj12 barrettj12 deleted the make-win branch December 16, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Makefile: runghc instead of runhaskell
3 participants