Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Nth-polynomials #740

Merged
merged 17 commits into from
Apr 3, 2022
Merged

Adding Nth-polynomials #740

merged 17 commits into from
Apr 3, 2022

Conversation

thomas-lamiaux
Copy link
Contributor

Adding nth-polynomials using a new definition

	- definition
	- ring structure
	- Equivalence with previous definition in one variable case
@felixwellen
Copy link
Collaborator

Interesting! Did you see Cubical/Algebra/CommAlgebra/Instances/FreeCommAlgebra.agda?
I think that is related to what you do. It seems you are a bit more economical with the constructors of your type of polynomials.

Btw: You can mark your pull-request as 'draft'. This is a good way to indicate, that it is work in progress.

- Add a proof of  this result
- Fix some paths
@thomas-lamiaux thomas-lamiaux marked this pull request as draft March 24, 2022 02:52
@thomas-lamiaux
Copy link
Contributor Author

Interesting! Did you see Cubical/Algebra/CommAlgebra/Instances/FreeCommAlgebra.agda? I think that is related to what you do. It seems you are a bit more economical with the constructors of your type of polynomials.

I didn't see it even though I am currently working with Anders, I think that they originated very differently.
Basically we were looking for a good definition of the direct-sum. Working with one we've come up with, I have realized that I could define nth-polynomials easily and it would simplify some latter proof.

Plus, I am not a big fan of the current one based on the :: operation. I prefer this one base on "vectorial space". With the difference that the action on the basis is internalized - which comes from the direct sum that is dependent - and seems to facilitate definition and proofs.
Indeed basically it suffices to specify the behavior for aX^n, to define functions such as the product so all structures rises and that simplify the structure.

Btw: You can mark your pull-request as 'draft'. This is a good way to indicate, that it is work in progress.

Indeed I forgot to do it, it's done thanks

- Clean up, name + better manadgment of module Poly n is now Poly A n where A is CommRing
  It is better if one need to  work with Poly A n and Poly B n.
- End of the proof that the functions defined in Equiv-Poly0-A, Equiv-Poly1-Poly, Comp-Poly are equivalence of CommRing
@thomas-lamiaux thomas-lamiaux marked this pull request as ready for review March 28, 2022 12:18
@thomas-lamiaux
Copy link
Contributor Author

Would adding a syntactic sugar like X^n1...X^nk for base [n1, ... nk] 1 be interesting ?

(I don't really know how to do so for any k)

Copy link
Collaborator

@mortberg mortberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please remove trailing whitespace

Cubical/Algebra/Polynomials/Nth-polynomials/Base.agda Outdated Show resolved Hide resolved
Cubical/Algebra/Polynomials/Nth-polynomials/Base.agda Outdated Show resolved Hide resolved
Cubical/Algebra/CommRing/Instances/Polynomials.agda Outdated Show resolved Hide resolved
Cubical/Algebra/Ring/Properties.agda Outdated Show resolved Hide resolved
Cubical/Algebra/Ring/Properties.agda Outdated Show resolved Hide resolved
Cubical/Algebra/CommRing/Properties.agda Outdated Show resolved Hide resolved
@thomas-lamiaux thomas-lamiaux requested a review from mortberg April 2, 2022 20:40
@mortberg
Copy link
Collaborator

mortberg commented Apr 3, 2022

There's still some trailing whitespace:

~/.cabal/bin/fix-whitespace --check
[ Violation detected ] Cubical/Algebra/Polynomials/Univariate/Properties.agda

@mortberg mortberg merged commit ab79d25 into agda:master Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants