-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Nth-polynomials #740
Conversation
- definition - ring structure - Equivalence with previous definition in one variable case
Interesting! Did you see Cubical/Algebra/CommAlgebra/Instances/FreeCommAlgebra.agda? Btw: You can mark your pull-request as 'draft'. This is a good way to indicate, that it is work in progress. |
- Add a proof of this result - Fix some paths
I didn't see it even though I am currently working with Anders, I think that they originated very differently. Plus, I am not a big fan of the current one based on the :: operation. I prefer this one base on "vectorial space". With the difference that the action on the basis is internalized - which comes from the direct sum that is dependent - and seems to facilitate definition and proofs.
Indeed I forgot to do it, it's done thanks |
- Clean up, name + better manadgment of module Poly n is now Poly A n where A is CommRing It is better if one need to work with Poly A n and Poly B n. - End of the proof that the functions defined in Equiv-Poly0-A, Equiv-Poly1-Poly, Comp-Poly are equivalence of CommRing
Would adding a syntactic sugar like X^n1...X^nk for base [n1, ... nk] 1 be interesting ? (I don't really know how to do so for any k) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please remove trailing whitespace
Cubical/Algebra/Polynomials/Nth-polynomials/CommRing-Structure.agda
Outdated
Show resolved
Hide resolved
Cubical/Algebra/Polynomials/Nth-polynomials/CommRing-Structure.agda
Outdated
Show resolved
Hide resolved
Cubical/Algebra/Polynomials/Nth-polynomials/Equiv/Comp-Poly.agda
Outdated
Show resolved
Hide resolved
Cubical/Algebra/Polynomials/Nth-polynomials/Equiv/Induced-Poly.agda
Outdated
Show resolved
Hide resolved
There's still some trailing whitespace:
|
Adding nth-polynomials using a new definition