Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ re #703, #743 ] Remove extend*Context #745

Merged
merged 1 commit into from
Mar 28, 2022
Merged

[ re #703, #743 ] Remove extend*Context #745

merged 1 commit into from
Mar 28, 2022

Conversation

L-TChen
Copy link
Member

@L-TChen L-TChen commented Mar 27, 2022

This is the only function incompatible with the development version 2.6.3 of Agda. It is not used elsewhere in the library.

Removing it makes the library compatible with Agda 2.6.3 again.

@L-TChen L-TChen mentioned this pull request Mar 27, 2022
Closed
@andreasabel
Copy link
Member

Removing it makes the library compatible with Agda 2.6.3 again.

Having a CI here that tests cubical with Agda master would be the perfect verification of this claim.

@L-TChen
Copy link
Member Author

L-TChen commented Mar 27, 2022

Here you are. https://github.com/L-TChen/agda/runs/5710346221?check_suite_focus=true

mortberg
mortberg approved these changes Mar 27, 2022
View reviewed changes
Copy link
Collaborator

@mortberg mortberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

@L-TChen L-TChen merged commit 2b389a0 into agda:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortberg mortberg mortberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@L-TChen @andreasabel @mortberg