Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway: make runs api related to project/user #310

Closed
sgotti opened this issue Feb 19, 2022 · 1 comment
Closed

gateway: make runs api related to project/user #310

sgotti opened this issue Feb 19, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@sgotti
Copy link
Member

sgotti commented Feb 19, 2022

Currently the gateway runs api are queried by the run id. The run id is meant to be a global sequence. From the user perspective or for other reason explained below it could be better to reference them by their project reference (i.e "org/org01/proj01", "user/user01/subproj/proj01") or user (for user direct run i.e. "user/user01") plus the related project run number (a sequential counter per project/user)
This is much more cleaner and could help for future improvements

*: Shard projects/users to multiple runservices. With the gateway currently receiving only a runid we cannot know which runservice owns a project/user.
*: Remove the need for a global (per runservice) sequence.

This will require changes also to the ui at https://github.com/agola-io/agola-web

I'm already working on it.

@sgotti sgotti added the enhancement New feature or request label Feb 19, 2022
@sgotti sgotti self-assigned this Feb 19, 2022
@sgotti
Copy link
Member Author

sgotti commented Mar 17, 2022

Implemented in #323

@sgotti sgotti closed this as completed Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant