-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparing the elm-package #3
Comments
What exactly do you mean by truncated? Can you show an example? |
In http://package.elm-lang.org/packages/bartavelle/json-helpers/1.0.0/Json-Helpers, look at the beginning of the chapter "Encoding schemes". The sum type has 3 members in the source code ... |
I mean 3 constructors. |
Looks like a bug in elms documentation generator... :-/ |
I have pushed a usable version of the elm package. I also have just pushed some changes in the elm-bridge package. I believe it is now releasable on hackage! There are still pain points (for example I don't like how I created an What do you think ? |
A very important change would be to document somewhere which elm library in which version is needed to be compatible. Could you also update the example? Apart from that I think we can cut another release. Please add your self as author the license and cabal file :-) |
Done! |
If it's ok with you I'll add it to stackage as soon as the release is made. |
Or perhaps I will not as the aeson bug isn't fixed yet :( |
Is our needed |
The currently required version is 0.9., but nightly now uses 0.10.. I am waiting for the new release because it contains a blocking bug ... |
Could you reference the aeson issue here? |
I suppose the stack issue itself is : haskell/aeson#328 |
I'll still release this to hackage and then we can make a minor release as soon as the stack issue is resolved. |
Sounds good to me! |
It will probably not be a minor release though, as the A solution to this would be to alter the code right now, drop the |
Sadly I'm currently not using this library anymore (We switched to https://github.com/typed-wire/typed-wire ), so it's up to you what will suit you best for your usecase. It would be cool if you could provide release notes for this release? :-) |
Let's wait on it a bit, I will do the refactoring in a few days and figure out a solution. I didn't realize this What did you have in mind for the release notes ? A changelog-like new file in the repo ? |
Yes, a changelog file would be great, just something so I can write up notes like this: https://github.com/agrafix/Spock/releases |
I just pushed a very succint changelog. Is that what you had in mind? The way newtypes are handled is now independant of instance generation, so |
Cool thank's! So we are ready for release? :-) |
I sure am! |
Release is up on hackage :-) Do you want to make the announcement? |
great! |
I published a formatted version of the elm package for testing, but I do not know why my code samples are truncated :(
I will keep on testing with a pair of real life projects until all of this is stable enough.
The text was updated successfully, but these errors were encountered: