Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove numpy.int and numpy.float #152

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Remove numpy.int and numpy.float #152

merged 1 commit into from
Feb 14, 2023

Conversation

EgorBlagov
Copy link
Contributor

These aliases are deprecated in numpy, can be ignored, since it's the same as regular int or float

@EgorBlagov
Remove numpy.int and numpy.float
203260b 
These aliases are deprecated in numpy, can be ignored, since it's the
same as regular int or float
@EgorBlagov EgorBlagov mentioned this pull request Dec 25, 2022
Closed
@traversaro traversaro mentioned this pull request Jan 13, 2023
Merged
10 tasks
@benman1
Copy link

benman1 commented Jan 14, 2023

@ahmedfgad could you please consider this PR? I think it might be very good to get this in.

@KukovecRok
Copy link

@ahmedfgad This solves the problem of importing the library. Please consider accepting this PR asap.

@rosejn
Copy link

rosejn commented Feb 9, 2023

This library is broken without this PR. Maybe this project needs a new maintainer?

@maederan201
Copy link

+1 it would be great to have this fixed such that the newest version of numpy can be used

@ahmedfgad ahmedfgad merged commit c1c9b88 into ahmedfgad:master Feb 14, 2023
@ahmedfgad
Copy link
Owner

Thanks everyone and apologize for the period of silence.
It is now merged. A new release will be pushed soon.

@EgorBlagov EgorBlagov deleted the fix-numpy-deprecated-types branch February 14, 2023 18:22
ahmedfgad added a commit that referenced this pull request Feb 14, 2023
@ahmedfgad
Scripts to create documentation locally
3e28140 
Release Date: 14 February 2023

1. Remove `numpy.int` and `numpy.float` from the list of supported data types. #151 #152
2. Call the `on_crossover()` callback function even if `crossover_type` is `None`. #138
3. Call the `on_mutation()` callback function even if `mutation_type` is `None`. #138
@ahmedfgad ahmedfgad added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedfgad ahmedfgad ahmedfgad approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@EgorBlagov @benman1 @KukovecRok @rosejn @maederan201 @ahmedfgad