From fdf8fde38767d3405d192e88199feacab5034574 Mon Sep 17 00:00:00 2001 From: Marek Siarkowicz Date: Thu, 1 Aug 2024 21:18:59 +0200 Subject: [PATCH] Remove flake caused failpoint in watch disrupting progress notifies Signed-off-by: Marek Siarkowicz --- tests/robustness/main_test.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/robustness/main_test.go b/tests/robustness/main_test.go index 2b1388d6454..63ba6b37763 100644 --- a/tests/robustness/main_test.go +++ b/tests/robustness/main_test.go @@ -96,8 +96,11 @@ func testRobustness(ctx context.Context, t *testing.T, lg *zap.Logger, s testSce t.Fatal(err) } - watchProgressNotifyEnabled := c.Cfg.ServerConfig.ExperimentalWatchProgressNotifyInterval != 0 - validateGotAtLeastOneProgressNotify(t, r.Client, s.watch.requestProgress || watchProgressNotifyEnabled) + failpointImpactingWatch := s.failpoint == failpoint.SleepBeforeSendWatchResponse + if !failpointImpactingWatch { + watchProgressNotifyEnabled := c.Cfg.ServerConfig.ExperimentalWatchProgressNotifyInterval != 0 + validateGotAtLeastOneProgressNotify(t, r.Client, s.watch.requestProgress || watchProgressNotifyEnabled) + } validateConfig := validate.Config{ExpectRevisionUnique: s.traffic.ExpectUniqueRevision()} r.Visualize = validate.ValidateAndReturnVisualize(t, lg, validateConfig, r.Client, persistedRequests, 5*time.Minute)