-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDSim: Change Default Output config #1144
Conversation
Any one has thoughts on "It is no longer possible to use the DD4hep root output of EDM4hep was used for the build."? I am not sure this is a good idea, sometimes probably nice for debugging... But I can't think of a nice and user friendly way at the moment. |
I would separate the file name from the output format and have some --lcio --edm4hep --root flags to determine the output format. If none is set, stay for backwards compatibility with the existing functionality. I know this even adds more flags, but ddsim anyhow lives from flags. |
520a330
to
bbc635a
Compare
I added some flags (outputConfig.forceLCIO, outputConfig.forceEDM4HEP, outputConfig.forceDD4HEP) to force a given output format. Thanks @MarkusFrankATcernch |
…o force a specific output plugin Move configuration to OutputConfig
bbc635a
to
88e828b
Compare
BEGINRELEASENOTES
DDSim: change the default output file name on how DD4hep was built. Fixes Adjust default output based on compiled format support #1101
DDSim: remove python2 legacy shims
Geant4UIManager: fail when pre or post run commands are not successfully executed.
ENDRELEASENOTES