Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EDM4hepOutput: determine momentum vector type automagically #1251

Merged
merged 1 commit into from
Apr 4, 2024
Merged

EDM4hepOutput: determine momentum vector type automagically #1251

merged 1 commit into from
Apr 4, 2024

Conversation

andresailer
Copy link
Member

BEGINRELEASENOTES

ENDRELEASENOTES

@andresailer andresailer requested a review from tmadlener April 3, 2024 15:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

Test Results

    8 files      8 suites   2h 29m 36s ⏱️
  363 tests   362 ✅ 0 💤 1 ❌
1 428 runs  1 427 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 8433c07.

@andresailer andresailer merged commit 4a5099b into AIDASoft:master Apr 4, 2024
12 of 14 checks passed
@andresailer andresailer deleted the edm4hepFlouble branch April 4, 2024 07:33
@tmadlener
Copy link
Contributor

If I had remembered this earlier, we could have also used this: https://github.com/key4hep/EDM4hep/blob/e27064f91cb1a8cdcbb840c6ff794dd1096f464a/utils/include/edm4hep/utils/vector_utils.h#L130-L132

@tmadlener tmadlener mentioned this pull request Jul 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EDM4hep output: ensure float / double is consistent with EDM4hep version used
2 participants
@andresailer @tmadlener