Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: drop possible use of PyROOT #1254

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

andresailer
Copy link
Member

@andresailer andresailer commented Apr 19, 2024

We no longer test with ROOT 6.22, and in 6.32 PyROOT is coming back but subtly fails on macOS

BEGINRELEASENOTES

  • CMake: drop possible use of ROOT::PyROOT target, always use ROOT::ROOTTPython
  • Python: remove the use of (dd)six, fix issues pointed out by new version of flake8

ENDRELEASENOTES

Accidentally picking up PyROOT leads to

ERROR: failed to load libDDG4Python.1.28.dylib: dlopen(libDDG4Python.1.28.dylib, 0x0005): symbol not found in flat namespace '__ZN9TPyReturnD1Ev'
...
ERROR: failed to load libDDPythonPlugins.1.28.dylib: dlopen(libDDPythonPlugins.1.28.dylib, 0x0005): symbol not found in flat namespace '__ZN7TPython4EvalEPKc'

We no longer test with ROOT 6.22, and in 6.32 PyROOT is coming back but subtly fails on macOS
@andresailer
Copy link
Member Author

There is a new version of flake8 in the nightly stack giving errors in python-lint

Copy link

Test Results

   14 files     14 suites   6h 42m 23s ⏱️
  363 tests   362 ✅ 0 💤 1 ❌
2 496 runs  2 495 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit cf2cd90.

@andresailer andresailer merged commit f08e335 into AIDASoft:master Apr 19, 2024
12 of 14 checks passed
@andresailer andresailer deleted the fixPyZombiePyroot branch April 19, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant