Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDSim: correct the number of events when running over all events (-1) #1258

Merged
merged 2 commits into from
May 7, 2024

Conversation

andresailer
Copy link
Member

@andresailer andresailer commented May 3, 2024

BEGINRELEASENOTES

  • DDSim: correct the number of events when running over all events (-1), fixes [ddsim] Get total number of events and time per event right #1257
  • GenerationActionInit: declare properties to access number of processed runs (numberOfRuns) and events (numberOfEVents)
  • DDG4: decode or eval all properties out of str or cppyy.gbl.string types

ENDRELEASENOTES

Copy link

github-actions bot commented May 3, 2024

Test Results

   14 files     14 suites   7h 4m 55s ⏱️
  363 tests   363 ✅ 0 💤 0 ❌
2 496 runs  2 496 ✅ 0 💤 0 ❌

Results for commit 991228d.

♻️ This comment has been updated with latest results.

@andresailer andresailer force-pushed the ddsimFixEventNumber branch from 01360b2 to 872ac4b Compare May 6, 2024 10:50
@@ -30,6 +30,8 @@ Geant4GeneratorActionInit::Geant4GeneratorActionInit(Geant4Context* ctxt, const
InstanceCount::increment(this);
context()->kernel().runAction().callAtEnd(this,&Geant4GeneratorActionInit::end);
context()->kernel().runAction().callAtBegin(this,&Geant4GeneratorActionInit::begin);
declareProperty("numberOfEvents", m_evtTotal);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarkusFrankATcernch
Is this the best way to let me read the number of events from the plugin, or is there something else that would be cleaner?

@MarkusFrankATcernch
Copy link
Contributor

@andresailer In principle there is a property
Geant4Kernel::NumEvents, which defines the number of events to be processed.
This property is then passed to Geant4Exec, where the G4 machinery is invoked.
Does this property not work or is this not sufficient to do the computation?

@andresailer
Copy link
Member Author

@andresailer In principle there is a property Geant4Kernel::NumEvents, which defines the number of events to be processed. This property is then passed to Geant4Exec, where the G4 machinery is invoked. Does this property not work or is this not sufficient to do the computation?

But here the number of events to be processed is going to be -1, so I want to check the actual counter of events processed.

@andresailer andresailer force-pushed the ddsimFixEventNumber branch from 872ac4b to 991228d Compare May 7, 2024 08:24
@MarkusFrankATcernch
Copy link
Contributor

@andresailer Correct.
Then this approach looks correct.

@andresailer
Copy link
Member Author

Thanks @MarkusFrankATcernch

@andresailer andresailer merged commit c63f900 into AIDASoft:master May 7, 2024
14 checks passed
@andresailer andresailer deleted the ddsimFixEventNumber branch May 7, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ddsim] Get total number of events and time per event right
2 participants