Set the edm4hep::MCParticle momentum as doubles once it becomes possible #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 6 files 6 suites 2h 34m 53s ⏱️ Results for commit c11833b. ♻️ This comment has been updated with latest results. |
|
Waiting for the EDM4hep change to go in first as that doesn't break DD4hep. This PR just avoids the precision loss from the explicit cast to |
andresailer
force-pushed
the
edm4hep-mcp-momentum-double
branch
2 times, most recently
from
bb2d178 to
492e3bb
Compare
tmadlener
force-pushed
the
edm4hep-mcp-momentum-double
branch
from
b8f2934 to
352eea7
Compare
tmadlener
force-pushed
the
edm4hep-mcp-momentum-double
branch
from
352eea7 to
c11833b
Compare
|
I think this can be merged now. I rebased it to trigger CI again. |
|
@tmadlener Should I merge ? |
|
Yes, this can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
edm4hep::MCParticleas double instead of float once it becomes possible.ENDRELEASENOTES
This should be backward compatible and keep working once key4hep/EDM4hep#237 is merged.