Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to ROOT 6.31. See issue https://github.com/AIDASoft/DD4hep/issues/1210 #1211

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

MarkusFrankATcernch
Copy link
Contributor

@MarkusFrankATcernch MarkusFrankATcernch commented Jan 12, 2024

BEGINRELEASENOTES

@andresailer
Copy link
Member

Please note that the ROOT in dev3 does not yet contain the changes, so build failures for dev3 are to be expected.

@MarkusFrankATcernch
Copy link
Contributor Author

@andresailer Yes, but this should be taken into account by the version number. No?
I though hope in https://lcgapp-services.cern.ch/cdash/upload/982612cdabd898ccd6b79a141231dcc6f0f5ede7/DD4hep-master-build.log the version number is higher as in the commit....

@MarkusFrankATcernch MarkusFrankATcernch changed the title Adapt to ROOT 6.31. See issue https://github.com/AIDASoft/DD4hep/issu… Adapt to ROOT 6.31. See issue https://github.com/AIDASoft/DD4hep/issues/1210 Jan 12, 2024
@andresailer
Copy link
Member

I think the version number for the development branch is only updated after the was a release, regardless of the interface changes along the way.

So this is not going to change from Yesterday to today.

https://github.com/root-project/root/blob/2c00a76c8fa58352151f7c83da936138a0bf2085/core/foundation/inc/ROOT/RVersion.hxx#L7

Copy link

Test Results

    6 files      6 suites   7h 8m 17s ⏱️
  359 tests   359 ✅ 0 💤 0 ❌
1 061 runs  1 061 ✅ 0 💤 0 ❌

Results for commit d018d5f.

@MarkusFrankATcernch MarkusFrankATcernch enabled auto-merge (rebase) January 12, 2024 13:36
@MarkusFrankATcernch MarkusFrankATcernch merged commit 0a2267e into AIDASoft:master Jan 12, 2024
14 checks passed
@andresailer andresailer linked an issue Jan 15, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes in ROOT master TGeo break DD4hep compilation
2 participants