Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASSIMP: adapt for changes in TGeoTesselated in ROOT #1212

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

andresailer
Copy link
Member

More issues https://lcgapp-services.cern.ch/cdash/upload/dc90a57b6947469d59a9ba12f3f24c333bce0c8a/DD4hep-master-build.log

Follow up for #1211

BEGINRELEASENOTES

  • Assimp: adapt to changes in TGeoTessellated for ROOT 6.32
  • ShapeUtilities: adapt to changes in TGeoTessellated for ROOT 6.32

ENDRELEASENOTES

Also need root-project/root#14339

Copy link

github-actions bot commented Jan 13, 2024

Test Results

  4 files    4 suites   3h 52m 15s ⏱️
356 tests 356 ✅ 0 💤 0 ❌
707 runs  707 ✅ 0 💤 0 ❌

Results for commit 3a72e7c.

♻️ This comment has been updated with latest results.

@dkonst13
Copy link

@andresailer @MarkusFrankATcernch LCG nightlies keep failing without this patch... Could you please have a look? Thanks!

@MarkusFrankATcernch
Copy link
Contributor

@dkonst13 Could you at least please post also a link to the build in LCG nightlies to see the exact failure? Thanks!

@MarkusFrankATcernch
Copy link
Contributor

@andresailer in ROOT_VERSION_CODE >= ROOT_VERSION(6,31,1) you need ">" and not ">=". Otherwise the compilation fails. Also had to learn it the hard way.....

@andresailer
Copy link
Member Author

@andresailer in ROOT_VERSION_CODE >= ROOT_VERSION(6,31,1) you need ">" and not ">=". Otherwise the compilation fails. Also had to learn it the hard way.....

No, to use the new code you have to use >=. I am exercising this branch locally against ROOT master HEAD. The version number for the development branch is not changing until the next release is done.

@andresailer andresailer marked this pull request as ready for review January 15, 2024 09:31
@andresailer andresailer force-pushed the tgeoFixes branch 2 times, most recently from 56e1759 to 2eb23a0 Compare January 15, 2024 16:16
@andresailer andresailer enabled auto-merge (rebase) January 15, 2024 17:04
@andresailer andresailer linked an issue Jan 15, 2024 that may be closed by this pull request
@andresailer andresailer disabled auto-merge January 15, 2024 20:11
@andresailer
Copy link
Member Author

Failures in dev3 expected.

@andresailer andresailer merged commit 5922c74 into AIDASoft:master Jan 15, 2024
12 of 14 checks passed
@andresailer andresailer deleted the tgeoFixes branch January 15, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes in ROOT master TGeo break DD4hep compilation
3 participants