Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DD4hep_DetectorDump plugin to avoid crash. #1228

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

MarkusFrankATcernch
Copy link
Contributor

@MarkusFrankATcernch MarkusFrankATcernch commented Feb 13, 2024

BEGINRELEASENOTES

  • Fix DD4hep_DetectorDump plugin to avoid crash if a DetElement placement is invalid,
    which is not allowed, but also should not end up in a crash.
  • Add test to check if DetElements have proper placement set using MiniTel example
    (see examples/ClientTests/compact/MiniTel_err_place.xml) and
    test MiniTel_check_missing_placements
  • The fake DD4hep object TwistedTube did not correctly emulate the different constructors when converted
    to Geant4. This should be fixed with this PR.
    ENDRELEASENOTES

@MarkusFrankATcernch
Copy link
Contributor Author

@bcouturi
This should fix the crash you got in the detector dump:
https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/497
Now the path of the detector element should be printed insead like:

DetectorDump     ERROR 004         /MyLHCBdetector1/side_0/module_9 DetElement with INVALID PLACEMENT!

Copy link

github-actions bot commented Feb 13, 2024

Test Results

    8 files      8 suites   3h 24m 41s ⏱️
  361 tests   361 ✅ 0 💤 0 ❌
1 420 runs  1 420 ✅ 0 💤 0 ❌

Results for commit 96318ce.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant