Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of leading underscore convention in non database storable Process inputs #1101

Closed
sphuber opened this issue Feb 2, 2018 · 1 comment

Comments

@sphuber
Copy link
Contributor

sphuber commented Feb 2, 2018

Originally the convention was that in order to mark Process inputs as non database storable, one had to use a name with a leading underscore. We now have a proper mixin, WithNonDb, for the InputPort which adds the non_db attribute, which when set to True indicates that it is not to be stored as a Node in the database. Old default work process inputs such as _label, _description and _options will have to be updated by removing the leading underscore and just use the attribute

@muhrin
Copy link
Contributor

muhrin commented Feb 12, 2018

Done in PR #1105.

@muhrin muhrin closed this as completed Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants