Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab completion not working for CalcJob.res #4184

Closed
giovannipizzi opened this issue Jun 18, 2020 · 4 comments · Fixed by #4187
Closed

Tab completion not working for CalcJob.res #4184

giovannipizzi opened this issue Jun 18, 2020 · 4 comments · Fixed by #4187
Assignees
Labels
Milestone

Comments

@giovannipizzi
Copy link
Member

Describe the bug

calcjob.res.<TAB> should complete the keys of the output dictionary, but it doesn't.

Steps to reproduce

Steps to reproduce the behavior:

  1. load a CalcJobNode that uses a plugin that supports the .res method and has parsed results
  2. Try to type calcjob.res. and press TAB twice. Nothing happens.

Expected behavior

Tab completion should work

Additional context

I addressed this in #3985 for .inputs, .outputs but I fear I forgot about .res.

@sphuber
Copy link
Contributor

sphuber commented Jun 19, 2020

Same here as for #4185 , if this is supposed to go in 1.3.0 which needs to be released early next week, who will take care of this one? I notice you haven't assigned yourself to this one, does that mean you won't have the time to fix it? @ramirezfranciscof maybe this is a good one for you?

@ramirezfranciscof
Copy link
Member

Sure, I can take a look at it at the begining of next week and we can discuss any trouble on wednesday!

@ramirezfranciscof ramirezfranciscof self-assigned this Jun 19, 2020
@sphuber sphuber added the priority/critical-blocking must be resolved before next release label Jun 19, 2020
@sphuber
Copy link
Contributor

sphuber commented Jun 19, 2020

I don't think we should let it wait that long. The plan was to release 1.3.0 on Monday or Tuesday at the latest, which means that we cannot wait with critical blocking PRs until after.

@ramirezfranciscof
Copy link
Member

Ah, sorry, I misinterpreted that you were proposing the first issue to tackle for the wednesday meetings.

@sphuber sphuber modified the milestones: v1.3.0, v1.2.2 Jun 22, 2020
@sphuber sphuber modified the milestones: v1.2.2, v1.3.0 Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants