Fix 1372 sqla attributes not current when read minimal #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue where because a node was in a Session, if any of the attributes of a Node were changed by an external process the getters would not see the change. I've put in an session.expire from SQLA to handle these cases. Also refactored AbstractNode a little.
* Removing references to node.dbnode() as much as possible as this should not be part of the public api * Fixed SQLA test for loading node type that is closest to missing plugin type * Added type attribute to concrete node classes
HOWEVER: This is only fixed on Nodes and not any other AiiDA type. This will have to be done later.
This was referenced Apr 5, 2018
|
@sphuber @muhrin @giovannipizzi This was merged too fast before I managed to interact. It should be Read committed based on the behaviour and what is mentioned at the links above.
|
muhrin
deleted the
fix_1372_sqla_attributes_not_current_when_read__minimal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1372 , the bug we found regarding node attributes not updating when changed externally.
I've also added a reasonably extensive test,
test_node_access_with_sessions, which checks this for the Nodes.