Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pycrypto dep on 0.12.2 #1754

Merged
merged 4 commits into from
Aug 13, 2018

Conversation

DropD
Copy link
Contributor

@DropD DropD commented Jul 17, 2018

No description provided.

giovannipizzi
giovannipizzi previously approved these changes Jul 17, 2018
Copy link
Member

@giovannipizzi giovannipizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@giovannipizzi
Copy link
Member

@DropD there are some pre-commit failures (possibly a different version of yapf?) Could you fix these? Also, please assign also someone else as I won't be able to check in the next few weeks

@sphuber
Copy link
Contributor

sphuber commented Aug 13, 2018

@DropD pre-commit is still failing due to requirements_for_rtd.txt discrepancy

@codecov-io
Copy link

Codecov Report

Merging #1754 into release_v0.12.2 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           release_v0.12.2    #1754   +/-   ##
================================================
  Coverage            54.48%   54.48%           
================================================
  Files                  246      246           
  Lines                32441    32441           
================================================
  Hits                 17677    17677           
  Misses               14764    14764

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0cf7c9...8a62fcf. Read the comment docs.

@sphuber sphuber self-requested a review August 13, 2018 15:36
@sphuber sphuber merged commit 003caf8 into aiidateam:release_v0.12.2 Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants