Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option --version to verdi to display current version #1811

Merged
merged 1 commit into from
Jul 28, 2018

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Jul 28, 2018

Fixes #1569 partially. The issue also requested the ability to detect where the current version is installed and if from a git repository which commit is checked out. I am not sure this is trivial to implement and should maybe be handled in a separate issue, as it would be good to already add this simplified version of the feature to develop.

@sphuber sphuber requested review from DropD and giovannipizzi July 28, 2018 14:08
@codecov-io
Copy link

Codecov Report

Merging #1811 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1811      +/-   ##
===========================================
+ Coverage    66.58%   66.61%   +0.02%     
===========================================
  Files          314      314              
  Lines        32346    32346              
===========================================
+ Hits         21538    21547       +9     
+ Misses       10808    10799       -9
Impacted Files Coverage Δ
aiida/backends/djsite/db/models.py 76.23% <0%> (+0.88%) ⬆️
aiida/backends/djsite/globalsettings.py 86.84% <0%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dfd4a8...b3492b2. Read the comment docs.

Copy link
Member

@giovannipizzi giovannipizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me. If getting the git version is complicated, maybe at least adding also the aiida.__path__?

@sphuber sphuber merged commit 9eb94f2 into aiidateam:develop Jul 28, 2018
@sphuber sphuber deleted the fix_1569_add_verdi_version branch July 28, 2018 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants