Separate JobProcess submit task in folder upload and scheduler submit #1946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1946 +/- ##
===========================================
- Coverage 67.61% 67.59% -0.03%
===========================================
Files 324 324
Lines 33305 33319 +14
===========================================
+ Hits 22520 22522 +2
- Misses 10785 10797 +12
Continue to review full report at Codecov.
|
|
Except I haven't touched the update tasks at all, right? |
muhrin
approved these changes
Oct 1, 2018
sphuber
force-pushed
the
fix_1940_submission_transport_separation
branch
from
82e21fd to
6e537ed
Compare
Originally, the submit TransportTask of a JobProcess included both the uploading of the work directory on the remote machine as well as the call to the scheduler to submit the job. These have now been separated into two separate TransportTasks, `upload` and `submit`, in order to provide finer grained control over the job process control flow.
sphuber
force-pushed
the
fix_1940_submission_transport_separation
branch
from
6e537ed to
4a8f131
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1940
Originally, the submit TransportTask of a JobProcess included both the
uploading of the work directory on the remote machine as well as the
call to the scheduler to submit the job. These have now been separated
into two separate TransportTasks,
uploadandsubmit, in order toprovide finer grained control over the job process control flow.