Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for verdi import when archive version is incompatible #1960

Merged

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Sep 12, 2018

Fixes #1947

Since there is a known solution to this problem, i.e. running verdi export migrate
it is best to inform the user of this instead of dumping a stack trace.

…mpatible

Since there is a known solution to this problem, i.e. running `verdi export migrate`
it is best to inform the user of this instead of dumping a stack trace.
@sphuber sphuber force-pushed the fix_1947_verdi_import_better_error_message branch from 2d8d267 to 3a04770 Compare September 12, 2018 11:37
@codecov-io
Copy link

Codecov Report

Merging #1960 into develop will decrease coverage by 0.02%.
The diff coverage is 14.81%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1960      +/-   ##
===========================================
- Coverage    67.59%   67.56%   -0.03%     
===========================================
  Files          324      324              
  Lines        33330    33342      +12     
===========================================
- Hits         22530    22529       -1     
- Misses       10800    10813      +13
Impacted Files Coverage Δ
aiida/orm/importexport.py 86.25% <100%> (ø) ⬆️
aiida/cmdline/commands/cmd_import.py 42.64% <8%> (-7.36%) ⬇️
...orm/implementation/general/calculation/__init__.py 79.74% <0%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82e35f8...3a04770. Read the comment docs.

@sphuber sphuber merged commit 3893c91 into aiidateam:develop Sep 12, 2018
@sphuber sphuber deleted the fix_1947_verdi_import_better_error_message branch September 12, 2018 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants