Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add from __future__ statements in all files #2100

Merged
merged 6 commits into from
Oct 24, 2018

Conversation

giovannipizzi
Copy link
Member

This fixes #2040
Note that we did NOT add unicode_literal as it was doing more harm than good (see discussion in the issue). Instead we added a few more, different ones (absolute_import, division, print_function).

@coveralls
Copy link

Coverage Status

Coverage increased (+8.3%) to 68.34% when pulling 02c3168 on giovannipizzi:fix_2040_unicode_literals into a3e8bbf on aiidateam:develop.

@coveralls
Copy link

coveralls commented Oct 23, 2018

Coverage Status

Coverage increased (+0.5%) to 68.34% when pulling 8a1aa99 on giovannipizzi:fix_2040_unicode_literals into c149362 on aiidateam:develop.

Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you feel like it, one could add a small check to remove empty lines above the imports, but that is of course just for the bonus points ;)

@giovannipizzi
Copy link
Member Author

That's easy, but I will do another time ;-)
Let me know if I should update the branch and merge or you will do it, thanks!

@sphuber sphuber merged commit f215998 into aiidateam:develop Oct 24, 2018
@giovannipizzi giovannipizzi deleted the fix_2040_unicode_literals branch December 6, 2018 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add unicode_literal from future to all files
3 participants