Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin fixtures: improve for pytest, add computer fixture to PluginTestCase #865

Merged
merged 3 commits into from
Oct 27, 2017

Conversation

DropD
Copy link
Contributor

@DropD DropD commented Oct 27, 2017

  • the fixture context manager now always returns the same FixtureManager instance (more would be useless, because it could not reload the dbenv anyway)
  • .travis-data/test_plugin_testcase.py now contains an example for a Computer fixture

Motivation for the second item: aiidateam/aiida-plugin-template#6

@ltalirz: The only significant thing i can see i am doing different is that i am ensuring that the workdir of the Computer is an existing directory.

@DropD DropD requested a review from ltalirz October 27, 2017 12:25
Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I now ran the new test on my machine and it worked as well - I wonder what the problem with the plugin template was... I'll have a look!

@ltalirz ltalirz merged commit f75ed6c into aiidateam:develop Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants