Added method_decorators into rest api resources #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltalirz
suggested changes
Dec 14, 2017
| @@ -192,6 +193,7 @@ def __init__(self, **kwargs): | |||
| self.utils_confs = {k: kwargs[k] for k in utils_conf_keys if k in | |||
| kwargs} | |||
| self.utils = Utils(**self.utils_confs) | |||
| self.method_decorators = {'get': kwargs.get('get_decorators', [])} | |||
There was a problem hiding this comment.
Ok, so is there a good reason why Node does not inherit from BaseResource?
The explanation below "class Node(Resource)" is not entirely clear to me, perhaps you could make it a docstring and expand it a little bit?
There was a problem hiding this comment.
NodeResource class is different from BaseResource in trans.set_query() mostly because it takes query_type as an input and the presence of additional result types like "tree". I have updated the doc string.
aiida/restapi/api.py
Outdated
| @@ -336,3 +335,4 @@ def handle_error(self, e): | |||
|
|
|||
| else: | |||
| raise e | |||
| """ | |||
There was a problem hiding this comment.
If you want to comment the function, please use # (don't make it a string).
Also, is there a better alternative to commenting it? Do we want to get rid of it or not?
waychal
pushed a commit
to waychal/aiida_core
that referenced
this pull request
Dec 18, 2017
…. This is now in the optional requirements. also update command-line for verdi data structure import using the qeinputparser
ltalirz
approved these changes
Dec 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
method_decorators keyword argument is added into rest api resources to pass the list of decorators to apply on endpoints