Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header of domain file getting added as a domain #98

Closed
DDelbarre opened this issue Jun 27, 2024 · 0 comments · Fixed by #100
Closed

Header of domain file getting added as a domain #98

DDelbarre opened this issue Jun 27, 2024 · 0 comments · Fixed by #100
Assignees
Labels
bug Something isn't working

Comments

@DDelbarre
Copy link
Collaborator

I was testing domain_mapping with a random JSON file from MetadataCatalogue, and decided to re-use the demo domain file (data-raw/domain_list_demo.csv). When domain_mapping loaded in the domain file it added the header row Domain_Name as one of the domains and was assigned code 5 (see screenshot below).

Screenshot 2024-06-27 at 17 02 19

I think that either the template needs to be changed to remove the header row, or the code will need to be modified to exclude the header when it loads in a domain file.

@DDelbarre DDelbarre added the bug Something isn't working label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants