Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump botocore #993

Closed
thehesiod opened this issue Jan 30, 2023 · 2 comments · Fixed by #999
Closed

Bump botocore #993

thehesiod opened this issue Jan 30, 2023 · 2 comments · Fixed by #999

Comments

@thehesiod
Copy link
Collaborator

started work in #974 however needs research into new async codepaths

@thehesiod thehesiod linked a pull request Jan 30, 2023 that will close this issue
@ppena-LiveData
Copy link

ppena-LiveData commented Feb 1, 2023

NOTE: this only bumps from botocore>=1.27.59,<1.27.60 to botocore>=1.27.92,<1.27.93, but that's not new enough to work with the new AWS IAM Identity Center SSO login and only works with the old AWS Single Sign-On, so botocore is always showing me SSOTokenLoadError('Error loading SSO Token: The SSO access token has either expired or is otherwise invalid.'), even though the token is not expired. How hard would it be to bump botocore to be >=1.29 (or whatever version adds support for AWS IAM Identity Center)?

@thehesiod
Copy link
Collaborator Author

we need to finish this one first, because there's a new async codepath, then we can do further bumps. Unfortunately it's a lot of work when they expose new codepaths that make network requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants