Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aiohttp #425

Merged
merged 10 commits into from
Nov 9, 2017
Merged

Update aiohttp #425

merged 10 commits into from
Nov 9, 2017

Conversation

jettify
Copy link
Member

@jettify jettify commented Nov 7, 2017

No description provided.

@codecov
Copy link

codecov bot commented Nov 7, 2017

Codecov Report

Merging #425 into master will increase coverage by 3.74%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
+ Coverage   83.49%   87.24%   +3.74%     
==========================================
  Files           8        8              
  Lines         515      486      -29     
==========================================
- Hits          430      424       -6     
+ Misses         85       62      -23
Impacted Files Coverage Δ
aiobotocore/endpoint.py 90.68% <100%> (+10.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc64a19...579ba50. Read the comment docs.

Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the PR :)

setup.py Outdated
@@ -9,7 +9,7 @@
# If adding requirements make sure to also add to requirements-dev.txt
install_requires = [
'botocore>=1.7.28, <=1.7.40',
'aiohttp>=2.0.4, <=2.3.0',
'aiohttp>=2.3.0, <=2.3.2',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Push <3.0.0 here.
All aiohttp 2.3 bugfixes should be backward compatible.
Honestly I don't expect many of them, maybe one or two with very minor changes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jettify jettify merged commit 534de67 into master Nov 9, 2017
@jettify jettify deleted the update-aiohttp branch November 9, 2017 21:46
# we can remove the following line and take advantage of
# aws gzip compression.
# See: https://github.com/aio-libs/aiohttp/issues/1992
headers['Accept-Encoding'] = 'identity'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jettify bug: we need to keep this identity until boto/botocore#1255 is fixed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, will bring back this lines.

@thehesiod
Copy link
Collaborator

@asvetlov thanks for the redirect and compression fixes!

@asvetlov
Copy link
Member

@thehesiod you are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants