Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_archive puts the file in memory #547

Open
AnthonyDeroche opened this issue Jan 13, 2021 · 1 comment
Open

get_archive puts the file in memory #547

AnthonyDeroche opened this issue Jan 13, 2021 · 1 comment

Comments

@AnthonyDeroche
Copy link

Long story short

When calling get_archive in containers.py, could you confirm that the whole file is stored in memory ?
If so with a large file, the machine could run out of memory.

What do you suggest to me if I want to get a stream to avoid storing the whole file in memory ?

Your environment

aiodocker 0.19.1
python 3.8.6
Linux

@asvetlov
Copy link
Member

Correct, the archive is stored in memory.
We should support an alternative API for streaming archive's data probably, PR is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants