Fix #2670: Process colon in path correctly. Release 2.3.9

CHANGES.rst

@@ -14,6 +14,11 @@ Changelog
 
 .. towncrier release notes start
 
+2.3.9 (2018-01-16)
+==================
+
+- Fix colon handing in path for dynamic resources (#2670)
+
 2.3.8 (2018-01-15)
 ==================
 

aiohttp/__init__.py

@@ -1,4 +1,4 @@
-__version__ = '2.3.8'
+__version__ = '2.3.9'
 
 # This relies on each of the submodules having an __all__ variable.
 

aiohttp/web_urldispatcher.py

@@ -427,7 +427,8 @@ def _match(self, path):
         if match is None:
             return None
         else:
-            return {key: URL(value, encoded=True).path for key, value in
+            return {key: URL.build(path=value, encoded=True).path
+                    for key, value in
                     match.groupdict().items()}
 
     def get_info(self):

tests/test_urldispatch.py

@@ -107,6 +107,18 @@ def test_add_with_matchdict(router):
     assert info.route.name is None
 
 
+@asyncio.coroutine
+def test_add_with_matchdict_with_colon(router):
+    handler = make_handler()
+    router.add_route('GET', '/handler/{to}', handler)
+    req = make_request('GET', '/handler/1:2:3')
+    info = yield from router.resolve(req)
+    assert info is not None
+    assert {'to': '1:2:3'} == info
+    assert handler is info.handler
+    assert info.route.name is None
+
+
 @asyncio.coroutine
 def test_add_route_with_add_get_shortcut(router):
     handler = make_handler()