Can't detect disconnection on wifi websocket client

[deunix-educ]

Long story short

I use several esp8266 (a wifi IOT) as websocket client with aiohttp 2.3.1 websocket server .
Works perfectly but i can't detect disconnection.

Expected behaviour

I want to detect disconnection when an esp8266 disappear.

Actual behaviour

I detect connections and play with all clients ESP8266. The method WebSocketResponse::_pong_not_received detecst all disconnections at heartbeat delay but do nothing.
I there any solution?

Steps to reproduce

A background loop to send a ping to all client esp8266.
WebSocketResponse instance with heartbeat param set.

Your environment

Debian machine + Python 3.5 + aiohttp v 2.3.1

[fafhrd91]

this seems like a bug.

[deunix-educ]

Probably by sending a message from WebSocketResponse._pong_not_received (after test) to WebSocketResponse.receive loop. I don't know to do how to do.

[deunix-educ]

I do not know if it's a good solution, but here is the code that allows me to detect the disconnection of all esp8266. :

import asyncio
from aiohttp import web

class WebSocketResponse(web.WebSocketResponse):
    def _pong_not_received(self):
        if self._req is not None and self._req.transport is not None:
            self._req.app.sockets.remove_ws(self) #  code that do the job

            self._closed = True
            self._close_code = 1006
            self._exception = asyncio.TimeoutError()
            self._req.transport.close()

[junqed]

Have you tried like in close method

aiohttp/aiohttp/client_ws.py

Line 132 in 5de1c0b

if self._waiting is not None and not self._closed:

?

I have the same thing — the pong callback doesn't stop reading loop :(

[junqed]

BTW it happens not in a wifi network

[anatoly-kussul]

Had same problem on wired network, adding receive_timeout to ws_connect solved this problem for me.
But i think this works only if you have infinite receiving loop (you will get asyncio.TimeoutError on await ws.receive())
async with session.ws_connect(url, proxy=proxy_url, heartbeat=1, receive_timeout=5) as ws: