all except BaseException should be except Exception

[hellysmile]

Long story short

#2383 fixed flake8 blind exception, but later for example #2441 used except BaseException

It should be fixed separately in 2.3 and master branches

Expected behaviour

everywhere should be except Exception

Actual behaviour

Some parts of code uses except Exception, some except BaseException

[fafhrd91]

For 2441 BaseException makes sense, especially because it just re-raise exception

[socketpair]

@asvetlov it is actual again. We need a linter.

See

aiohttp/aiohttp/client_reqrep.py

Line 974 in 7a324fd

except BaseException:

for example. Exception in close() prevent, for example, exitting from the application.

[asvetlov]

No.
The code catches an exception, closes the response and reraises the exception again.
It should work pretty fine with CancelledError, isn't it?

Exception in close() unwinds the stack anyway.

[socketpair]

Yes, unwinds, but exception in .close() will REPLACE, say, SystemExit exception, does not it ?

[asvetlov]

Chicken-egg problem.
I have a feeling that a response should be closed in case of exception.
The question is: how should look like an exception in finalizer.
@socketpair do you have a suggestion?

[socketpair]

1. We should track only except Exception (and CancelledError also, if applicable).
2. AFAIK, calling close() - just an GC optimisation. In good code, GC should kill such items.
3. Another option - try...except...warning+ignore wrapper over close().

There are plenty of exceptions, which are not errors actually. It's wrong design. Like Stopiteration,systemexit,Cancellederror....We should close something only by ERROR. If someone raises such exceptions it should understand what will happen.

That's my opinion.