Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong type annotation for local_addr in TCPConnector.__init__ #3639

Closed
quonb opened this issue Mar 6, 2019 · 2 comments
Closed

Wrong type annotation for local_addr in TCPConnector.__init__ #3639

quonb opened this issue Mar 6, 2019 · 2 comments
Labels
bug outdated

Comments

@quonb
Copy link

quonb commented Mar 6, 2019

aiohttp/aiohttp/connector.py

Line 717 in f489a92

local_addr: Optional[str]=None,

Should not it be Optional[Tuple[str, int]]?
@aio-libs-bot
Copy link

GitMate.io thinks the contributor most likely able to help you is @asvetlov.

Possibly related issues are #2224 (aiohttp.TCPConnector()), #3595 (Wrong type hint for tracing Signal sequence), #3230 (iter_chunks type annotation wrong), #2377 (Drop resovle param from TCPConnector), and #662 (ClientResponseError wrong error propagation?).

@quonb quonb changed the title Wrong type for local_addr in TCPConnector.__init__ Wrong type annotation for local_addr in TCPConnector.__init__ Mar 6, 2019
@Hanaasagi Hanaasagi mentioned this issue Mar 19, 2019
Closed
@mathdugre mathdugre mentioned this issue May 7, 2019
Merged
5 tasks
@asvetlov
Copy link
Member

asvetlov commented May 7, 2019

Fixed by #3732

@asvetlov asvetlov closed this as completed May 7, 2019
@lock lock bot added the outdated label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix local_addr annotation in TCPConnector.__init__ Hanaasagi/aiohttp
3 participants
@asvetlov @quonb @aio-libs-bot