Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientResponseError wrong error propagation? #662

Closed
AlJohri opened this issue Dec 6, 2015 · 3 comments
Closed

ClientResponseError wrong error propagation? #662

AlJohri opened this issue Dec 6, 2015 · 3 comments
Labels

Comments

@AlJohri
Copy link

AlJohri commented Dec 6, 2015

In the client, I believe you catch ServerDisconnectedError and a couple other errors and propagate as ClientResponseError with __cause__ set as the real error. I think some other place in the code, I'm getting the raw "ServerDisconnectedError". Realized this since I wasn't catching the error.

Usually: ClientResponseError with cause ServerDisconnectedError
Sometimes: ServerDisconnectedError with cause ConnectionResetError

Is this by design?

@fafhrd91
Copy link
Member

fafhrd91 commented Feb 1, 2017

ServerDisconnectedError means server dropped connection before completing response.
in second case is second case you probably should get ConnectionResetError

exception handling needs some cleanup

@fafhrd91
Copy link
Member

client does not catch ServerDisconnectedError anymore

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants