Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading "Running on..." message #832

Closed
ygravrand opened this issue Mar 18, 2016 · 2 comments
Closed

Misleading "Running on..." message #832

ygravrand opened this issue Mar 18, 2016 · 2 comments
Labels
Milestone

Comments

@ygravrand
Copy link

Long story short

The console message output by web:run_app is misleading when one binds on 0.0.0.0 (the default): it says 127.0.0.1, so one can think it's listening on local interface only.
I can provide a simple PR modifying the aiohttp/web.py:312 line.
Also, maybe it would be good practise to make the default 127.0.0.1?

Expected behaviour

======== Running on http://0.0.0.0:8000/ ========
(Press CTRL+C to quit)

Actual behaviour

======== Running on http://127.0.0.1:8000/ ========
(Press CTRL+C to quit)

Steps to reproduce

Simply call web.run_app as in the examples

@asvetlov asvetlov added this to the 0.22 milestone Mar 18, 2016
@asvetlov
Copy link
Member

Fixed by a1f39a9
Thanks

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants