MultipartReader does not support multipart data with a preamble #880
Labels
Comments
obmarg
added a commit
to obmarg/aiohttp
that referenced
this issue
May 19, 2016
This updates the MultipartReader to ignore the preamble of a multipart message. To quote the RFC: > There appears to be room for additional information prior to the first > boundary delimiter line and following the final boundary delimiter line. > These areas should generally be left blank, and implementations must > ignore anything that appears before the first boundary delimiter line or > after the last one. To do this, the MultipartReader now acts slightly differently at the beginning of the file. Instead of looking for a boundary and excepting if it doesn't find one, it will skip over the initial data looking for the first boundary and start reading from there. If it doesn't find any boundary, it will except similar to how it did before. Fixes aio-libs#880
obmarg
added a commit
to obmarg/aiohttp
that referenced
this issue
May 19, 2016
This updates the MultipartReader to ignore the preamble of a multipart message. To quote the RFC: > There appears to be room for additional information prior to the first > boundary delimiter line and following the final boundary delimiter line. > These areas should generally be left blank, and implementations must > ignore anything that appears before the first boundary delimiter line or > after the last one. To do this, the MultipartReader now acts slightly differently at the beginning of the file. Instead of looking for a boundary and excepting if it doesn't find one, it will skip over the initial data looking for the first boundary and start reading from there. If it doesn't find any boundary, it will except similar to how it did before. Fixes aio-libs#880
obmarg
added a commit
to obmarg/aiohttp
that referenced
this issue
May 19, 2016
This updates the MultipartReader to ignore the preamble of a multipart message. To quote the RFC: > There appears to be room for additional information prior to the first > boundary delimiter line and following the final boundary delimiter line. > These areas should generally be left blank, and implementations must > ignore anything that appears before the first boundary delimiter line or > after the last one. To do this, the MultipartReader now acts slightly differently at the beginning of the file. Instead of looking for a boundary and excepting if it doesn't find one, it will skip over the initial data looking for the first boundary and start reading from there. If it doesn't find any boundary, it will except similar to how it did before. Fixes aio-libs#880
|
@kxepal ? |
|
@fafhrd91 hm? I guess that issue is linked with the PR you pinged a little bit before now, no? |
|
ok |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Long story short
I'm using the MultipartReader to read multi-part data from a 3rd party API. It's response has an extra CRLF pair before the first boundary marker.
It appears from reading the RFC that it's valid to include a preamble before the first boundary, and it should just be ignored
I'm passing a response from this server through
aiohttp.MultipartReader.from_responseand then calling.next()Expected behaviour
aiohttp ignores the preamble and returns the first part.
Actual behaviour
I get the exception:
Steps to reproduce
I've added a failing unit test here: obmarg@8724035
Your environment
Not sure any of it's relevant, but: MacOS, python 3.5.1, aiohttp 0.19.0 (though reproduced with master).
The text was updated successfully, but these errors were encountered: